Capture exceptions to Sentry instead of printing#55
Closed
sethmlarson wants to merge 1 commit into
Closed
Conversation
sethmlarson
force-pushed
the
sentry-errors
branch
from
58c7ef1 to
f21522d
Compare
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Seth, can we please create branches on our forks rather than the public repository?
| return | ||
| raise | ||
| # Capture the original exception in Sentry (private) | ||
| # and emit a sanitized public exception. |
Member
There was a problem hiding this comment.
# and emit a sanitized public exception.I think you forgot that bit ;-)
Collaborator
Author
|
@StanFromIreland Yes I need to switch over now that we're public, thanks for the reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of printing errors to the public log we capture them into Sentry instead.